mirror of
https://github.com/ruby/ruby.git
synced 2026-07-29 22:34:58 +08:00
The nt scheduling loop reclaimed a terminated coroutine thread's context using the return value of coroutine_transfer() (through thread_sched_switch0), assuming it was the resuming context (the dead coroutine). That holds for the amd64 asm backend, but the ucontext backend returns the transfer *target* instead, so the loop never recognized the terminal transfer: the reclaim always saw a live thread, and the loop always unlocked the sched lock -- which the dying thread had already released in coroutine_thread_terminated -- and double-unlocked it. Benign on glibc, but FreeBSD's pthread_mutex_unlock returns EPERM (crash), and it corrupts the scheduler (hang) elsewhere. Have the terminating coroutine record its own context in nt->dead_co (per native thread) right before its final transfer; the loop reads it after switch0 returns, independent of coroutine_transfer()'s backend-dependent return value. It is set and read on the same native thread with nothing running in between, so it cannot be overwritten before it is consumed. coroutine_transfer0() and thread_sched_switch0() no longer need to return the resuming context, so revert them to void (the ASan-only local remains). Reproduced on Linux with --with-coroutine=ucontext (100% hang before, clean after); amd64 and ucontext both pass bootstraptest thread/ractor/fiber. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
201 lines
5.9 KiB
C
201 lines
5.9 KiB
C
#ifndef RUBY_THREAD_PTHREAD_H
|
|
#define RUBY_THREAD_PTHREAD_H
|
|
/**********************************************************************
|
|
|
|
thread_pthread.h -
|
|
|
|
$Author$
|
|
|
|
Copyright (C) 2004-2007 Koichi Sasada
|
|
|
|
**********************************************************************/
|
|
|
|
#ifdef HAVE_PTHREAD_NP_H
|
|
#include <pthread_np.h>
|
|
#endif
|
|
|
|
#define RB_NATIVETHREAD_LOCK_INIT PTHREAD_MUTEX_INITIALIZER
|
|
#define RB_NATIVETHREAD_COND_INIT PTHREAD_COND_INITIALIZER
|
|
|
|
// TLS can not be accessed across .so on arm64 and perhaps ppc64le too.
|
|
#if defined(__arm64__) || defined(__aarch64__) || defined(__powerpc64__)
|
|
# define RB_THREAD_CURRENT_EC_NOINLINE
|
|
#endif
|
|
|
|
// this data should be protected by timer_th.waiting_lock
|
|
struct rb_thread_sched_waiting {
|
|
enum thread_sched_waiting_flag {
|
|
thread_sched_waiting_none = 0x00,
|
|
thread_sched_waiting_timeout = 0x01,
|
|
thread_sched_waiting_io_read = 0x02,
|
|
thread_sched_waiting_io_write = 0x08,
|
|
thread_sched_waiting_io_force = 0x40, // ignore readable
|
|
} flags;
|
|
|
|
struct {
|
|
// should be compat with hrtime.h
|
|
#ifdef MY_RUBY_BUILD_MAY_TIME_TRAVEL
|
|
int128_t timeout;
|
|
#else
|
|
uint64_t timeout;
|
|
#endif
|
|
uint32_t event_serial;
|
|
int fd; // -1 for timeout only
|
|
int result;
|
|
} data;
|
|
|
|
// connected to timer_th.waiting
|
|
struct ccan_list_node node;
|
|
};
|
|
|
|
// per-Thread scheduler helper data
|
|
struct rb_thread_sched_item {
|
|
struct {
|
|
struct ccan_list_node ubf;
|
|
|
|
// connected to ractor->threads.sched.reqdyq
|
|
// locked by ractor->threads.sched.lock
|
|
struct ccan_list_node readyq;
|
|
// Indicates whether thread is on the readyq.
|
|
// There is no clear relationship between this and th->status.
|
|
bool is_ready;
|
|
|
|
// connected to vm->ractor.sched.timeslice_threads
|
|
// locked by vm->ractor.sched.lock
|
|
struct ccan_list_node timeslice_threads;
|
|
|
|
// connected to vm->ractor.sched.running_threads
|
|
// locked by vm->ractor.sched.lock
|
|
struct ccan_list_node running_threads;
|
|
|
|
} node;
|
|
|
|
struct rb_thread_sched_waiting waiting_reason;
|
|
uint32_t event_serial;
|
|
|
|
bool malloc_stack;
|
|
void *context_stack;
|
|
size_t context_stack_size;
|
|
struct coroutine_context *context;
|
|
};
|
|
|
|
struct rb_native_thread {
|
|
rb_atomic_t serial;
|
|
struct rb_vm_struct *vm;
|
|
|
|
rb_nativethread_id_t thread_id;
|
|
|
|
#ifdef RB_THREAD_T_HAS_NATIVE_ID
|
|
int tid;
|
|
#endif
|
|
|
|
struct rb_thread_struct *running_thread;
|
|
|
|
// to control native thread
|
|
#if defined(__GLIBC__) || defined(__FreeBSD__)
|
|
union
|
|
#else
|
|
/*
|
|
* assume the platform condvars are badly implemented and have a
|
|
* "memory" of which mutex they're associated with
|
|
*/
|
|
struct
|
|
#endif
|
|
{
|
|
rb_nativethread_cond_t intr; /* th->interrupt_lock */
|
|
rb_nativethread_cond_t readyq; /* use sched->lock */
|
|
} cond;
|
|
|
|
#ifdef USE_SIGALTSTACK
|
|
void *altstack;
|
|
#endif
|
|
|
|
struct coroutine_context *nt_context;
|
|
int dedicated;
|
|
|
|
// A terminating coroutine records its context here before its final
|
|
// transfer; this nt's loop reclaims it. (Not via coroutine_transfer()'s
|
|
// return value: its meaning differs between the amd64 asm and ucontext.)
|
|
struct coroutine_context *dead_co;
|
|
};
|
|
|
|
#undef except
|
|
#undef try
|
|
#undef leave
|
|
#undef finally
|
|
|
|
// per-Ractor
|
|
struct rb_thread_sched {
|
|
rb_nativethread_lock_t lock_;
|
|
#if VM_CHECK_MODE
|
|
struct rb_thread_struct *lock_owner;
|
|
#endif
|
|
struct rb_thread_struct *running; // running thread or NULL
|
|
// Most recently running thread or NULL. If this thread wakes up before the newly running
|
|
// thread completes the transfer of control, it can interrupt and resume running.
|
|
// The new thread clears this field when it takes control.
|
|
struct rb_thread_struct *runnable_hot_th;
|
|
int runnable_hot_th_waiting;
|
|
bool is_running;
|
|
bool is_running_timeslice;
|
|
bool enable_mn_threads;
|
|
|
|
struct ccan_list_head readyq;
|
|
int readyq_cnt;
|
|
// ractor scheduling
|
|
// When not linked in vm->ractor.sched.grq, this node is kept
|
|
// self-linked (ccan_list_node_init), so "linked?" can be read off the
|
|
// node itself: enqueuers assert it, and direct transfers cancel an
|
|
// outstanding entry (see ractor_sched_cancel_enq).
|
|
struct ccan_list_node grq_node;
|
|
};
|
|
|
|
struct rb_thread_context;
|
|
|
|
// A coroutine (M:N) thread's teardown runs coroutine_thread_terminated
|
|
// instead of the dedicated-thread path in thread_start_func_2; see the
|
|
// comments there and in thread_pthread_mn.c. th->sched.context is cleared in
|
|
// that epilogue, so this also reads as "did not tear down yet".
|
|
// (Only meaningful when USE_MN_THREADS -- gate uses accordingly; the macro
|
|
// itself is a plain pointer test and always compiles.)
|
|
#define th_has_coroutine(th) ((th)->sched.context != NULL)
|
|
|
|
#ifdef RB_THREAD_LOCAL_SPECIFIER
|
|
NOINLINE(void rb_current_ec_set(struct rb_execution_context_struct *));
|
|
|
|
# ifdef RB_THREAD_CURRENT_EC_NOINLINE
|
|
NOINLINE(struct rb_execution_context_struct *rb_current_ec(void));
|
|
# else
|
|
RUBY_EXTERN RB_THREAD_LOCAL_SPECIFIER struct rb_execution_context_struct *ruby_current_ec;
|
|
|
|
// for RUBY_DEBUG_LOG()
|
|
RUBY_EXTERN RB_THREAD_LOCAL_SPECIFIER rb_atomic_t ruby_nt_serial;
|
|
#define RUBY_NT_SERIAL 1
|
|
# endif
|
|
#else
|
|
typedef pthread_key_t native_tls_key_t;
|
|
|
|
static inline void *
|
|
native_tls_get(native_tls_key_t key)
|
|
{
|
|
// return value should be checked by caller
|
|
return pthread_getspecific(key);
|
|
}
|
|
|
|
static inline void
|
|
native_tls_set(native_tls_key_t key, void *ptr)
|
|
{
|
|
if (UNLIKELY(pthread_setspecific(key, ptr) != 0)) {
|
|
rb_bug("pthread_setspecific error");
|
|
}
|
|
}
|
|
|
|
RUBY_EXTERN native_tls_key_t ruby_current_ec_key;
|
|
#endif
|
|
|
|
struct rb_ractor_struct;
|
|
void rb_ractor_sched_wait(struct rb_execution_context_struct *ec, struct rb_ractor_struct *cr, rb_unblock_function_t *ubf, void *ptr);
|
|
void rb_ractor_sched_wakeup(struct rb_ractor_struct *r, struct rb_thread_struct *th);
|
|
|
|
#endif /* RUBY_THREAD_PTHREAD_H */
|