mirror of
https://github.com/ruby/ruby.git
synced 2026-11-08 01:20:26 +08:00
2a8f329f59
object_id took the VM lock for every shareable object in multi-Ractor mode, even
when the object already had an id.
Kernel#hash reaches object_id through rb_obj_hash, so a shareable T_DATA such as
an Encoding, a Ractor or a Ractor::Port used as a Hash key serialised every
lookup across Ractors.
In this commit we make generic_field_set copy the fields of a shareable object
in multi-Ractor mode, and publish the new fields_obj of a T_DATA with an atomic
write.
```ruby
t = Process.clock_gettime(Process::CLOCK_MONOTONIC)
ractors = 4.times.map do
Ractor.new do
h = { Encoding::UTF_8 => 1 }
1_000_000.times { h[Encoding::UTF_8] }
end
end
ractors.each(&:join)
elapsed = Process.clock_gettime(Process::CLOCK_MONOTONIC) - t
puts "#{elapsed.round(2)}s"
```
I ran this 3 times before this patch and after and saw
before: 0.58s 0.61s 0.64s
after: 0.05s 0.05s 0.05s
83 lines
3.6 KiB
C
83 lines
3.6 KiB
C
#ifndef INTERNAL_VARIABLE_H /*-*-C-*-vi:se ft=c:*/
|
|
#define INTERNAL_VARIABLE_H
|
|
/**
|
|
* @author Ruby developers <ruby-core@ruby-lang.org>
|
|
* @copyright This file is a part of the programming language Ruby.
|
|
* Permission is hereby granted, to either redistribute and/or
|
|
* modify this file, provided that the conditions mentioned in the
|
|
* file COPYING are met. Consult the file for details.
|
|
* @brief Internal header for variables.
|
|
*/
|
|
#include "ruby/internal/config.h"
|
|
#include <stddef.h> /* for size_t */
|
|
#include "constant.h" /* for rb_const_entry_t */
|
|
#include "ruby/internal/stdbool.h" /* for bool */
|
|
#include "ruby/ruby.h" /* for VALUE */
|
|
#include "shape.h" /* for shape_id_t */
|
|
|
|
/* variable.c */
|
|
void rb_gc_mark_global_tbl(void);
|
|
void rb_gc_update_global_tbl(void);
|
|
VALUE rb_search_class_path(VALUE);
|
|
VALUE rb_attr_delete(VALUE, ID);
|
|
void rb_autoload_str(VALUE mod, ID id, VALUE file);
|
|
VALUE rb_autoload_at_p(VALUE, ID, int);
|
|
NORETURN(VALUE rb_mod_const_missing(VALUE,VALUE));
|
|
rb_gvar_getter_t *rb_gvar_getter_function_of(ID);
|
|
rb_gvar_setter_t *rb_gvar_setter_function_of(ID);
|
|
void rb_gvar_readonly_setter(VALUE v, ID id, VALUE *_);
|
|
void rb_gvar_ractor_local(const char *name);
|
|
void rb_gvar_box_ready(const char *name);
|
|
void rb_gvar_box_dynamic(const char *name);
|
|
|
|
/**
|
|
* Sets the name of a module.
|
|
*
|
|
* Non-permanently named classes can have a temporary name assigned (or
|
|
* cleared). In that case the name will be used for `#inspect` and `#to_s`, and
|
|
* nested classes/modules will be named with the temporary name as a prefix.
|
|
*
|
|
* After the module is assigned to a constant, the temporary name will be
|
|
* discarded, and the name will be computed based on the nesting.
|
|
*
|
|
* @param[in] mod An instance of ::rb_cModule.
|
|
* @param[in] name An instance of ::rb_cString.
|
|
* @retval mod
|
|
*/
|
|
VALUE rb_mod_set_temporary_name(VALUE, VALUE);
|
|
|
|
void rb_obj_replace_fields(VALUE obj, VALUE fields_obj);
|
|
VALUE rb_obj_complex_fields_build(VALUE obj);
|
|
VALUE rb_obj_field_get(VALUE obj, shape_id_t target_shape_id);
|
|
VALUE rb_imemo_fields_field_get(VALUE fields_obj, shape_id_t target_shape_id);
|
|
void rb_ivar_set_internal(VALUE obj, ID id, VALUE val);
|
|
void rb_check_ivar_modifiable(VALUE obj);
|
|
void rb_ivar_foreach_buffered(VALUE obj, int (*func)(ID name, VALUE val, st_data_t arg), st_data_t arg);
|
|
attr_index_t rb_ivar_set_index(VALUE obj, ID id, VALUE val);
|
|
attr_index_t rb_obj_field_set(VALUE obj, shape_id_t target_shape_id, ID field_name, VALUE val);
|
|
VALUE rb_ivar_get_at(VALUE obj, attr_index_t index, ID id);
|
|
VALUE rb_ivar_get_at_no_ractor_check(VALUE obj, attr_index_t index);
|
|
void rb_generic_fields_lock_atfork(void);
|
|
void rb_imemo_fields_record_shrefs(VALUE fields_obj);
|
|
|
|
/* Call cb(tbl, arg) for the single global generic_fields table. Used by the global GC's weak
|
|
* pass and by compaction's reference update (gc.c). */
|
|
void rb_generic_fields_tables_foreach(void (*cb)(struct st_table *tbl, void *arg), void *arg);
|
|
void rb_generic_fields_shared_table_foreach(void (*cb)(struct st_table *tbl, void *arg), void *arg);
|
|
|
|
RUBY_SYMBOL_EXPORT_BEGIN
|
|
/* variable.c (export) */
|
|
void rb_mark_generic_ivar(VALUE obj);
|
|
VALUE rb_const_missing(VALUE klass, VALUE name);
|
|
bool rb_class_ivar_set(VALUE klass, ID vid, VALUE value);
|
|
void rb_fields_tbl_copy(VALUE dst, VALUE src);
|
|
RUBY_SYMBOL_EXPORT_END
|
|
|
|
VALUE rb_ivar_lookup(VALUE obj, ID id, VALUE undef);
|
|
VALUE rb_gvar_get(ID);
|
|
VALUE rb_gvar_set(ID, VALUE);
|
|
VALUE rb_gvar_defined(ID);
|
|
void rb_const_warn_if_deprecated(const rb_const_entry_t *, VALUE, ID);
|
|
|
|
#endif /* INTERNAL_VARIABLE_H */
|