mirror of
https://pdfium.googlesource.com/pdfium
synced 2026-07-31 22:26:36 +08:00
65db368888
Embedder tests often install stack-local delegates, but EmbedderTest can invoke delegate callbacks while closing the document in TearDown(). By then, a stack delegate may already have been destroyed. Add SetOwnedDelegate() so the fixture owns the custom delegate through document teardown, then restores the default delegate before releasing it. Migrate all existing call sites, remove the raw SetDelegate() API, and store the active delegate as an UnownedPtr. Bug: 535697671 Change-Id: I8e8da028e9c563e82d40099637c63978122077eb Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/152110 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
There are two separate wrappers for V8 here. One is called FXJS, and
it is used by the non-XFA code. The other is called FXJSE, and it is
used only by the XFA code. Additionally FXJSE may request services
from FXJS to bridge the two.
Both the FXJS and FXJSE binding code needs to be replaced by something
saner, perhaps Gin or perhaps some IDL. See
https://bugs.chromium.org/p/pdfium/issues/detail?id=716
for progress on the issue.
FXJS binds objects by sticking a pointer to a CFXJS_PerObjectData in
the V8 object's internal slot. FXJSE binds objects by sticking a
pointer to either an actual v8 function object or a CFXJSE_HostObject
in the V8 object's internal slot, depending upon whether the object
represents (in some notion) a "class" or an "instance". Also, V8 objects
bound in one library may unexpectedly arrive at the other given a script
that's trying to mess with us.
To distinguish these cases, we use two internal slots for all bound
objects, regardless of the FXJS/FXJSE distinction. Slot 0 is the
tag and contains either:
kPerObjectDataTag for FXJS objects, or
kFXJSEHostObjectTag for FXJSE global objects, or
One of 4 specific FXJSE_CLASS_DESCRIPTOR globals for FXJSE classes:
kGlobalClassDescriptor
kNormalClassDescriptor
kVariablesClassDescriptor
kFormCalcDescriptor
Slot 1's contents are determined by these tags:
kPerObjectDataTag means an aligned pointer to CFXJS_PerObjectData.
kFXJSEHostObjectTag means an aligned pointer to CFXJSE_HostObject.
A FXJSE_CLASS_DESCRIPTOR pointer means to expect an actual v8 function
object (or a string naming that function), and not an aligned pointer.
Because PDFium uses V8 for various unrelated purposes, there may be up to
four v8::Contexts (JS Global Objects) associated with each document. One is
used by FXJS and holds objects as described by the js_api_reference.pdf
specification. The others are used by FXJSE.