mirror of
https://pdfium.googlesource.com/pdfium
synced 2026-08-02 05:04:39 +08:00
dc4e60e8e8
These were missed by the PDFium probing-style detector because the raw_ptr<> were never destroyed. LSAN could not find it either, since the memory was not leaked, just the dangling references were not cleaned up beforehand. The reason is that we have C++ classes inheriting from C-style structs, hence there can not be virtual destructors. When holding an unique_ptr<> to the C-style struct, the subclass is never destructed. After this CL lands, we should be able to make the build bots set the GN variable `enable_dangling_raw_ptr_checks=true`. If that were set today, hopefully it would flag the issue. Change-Id: I631b2e07670e1e09111ffa9f35e600cc42b15323 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/112410 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
47 lines
1.2 KiB
C++
47 lines
1.2 KiB
C++
// Copyright 2017 The PDFium Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef TESTING_FAKE_FILE_ACCESS_H_
|
|
#define TESTING_FAKE_FILE_ACCESS_H_
|
|
|
|
#include <memory>
|
|
|
|
#include "core/fxcrt/unowned_ptr.h"
|
|
#include "public/fpdf_dataavail.h"
|
|
#include "public/fpdfview.h"
|
|
#include "testing/range_set.h"
|
|
|
|
class DownloadHintsImpl;
|
|
class FileAccessWrapper;
|
|
class FileAvailImpl;
|
|
|
|
class FakeFileAccess {
|
|
public:
|
|
explicit FakeFileAccess(FPDF_FILEACCESS* file_access);
|
|
~FakeFileAccess();
|
|
|
|
FPDF_FILEACCESS* GetFileAccess() const;
|
|
FX_FILEAVAIL* GetFileAvail() const;
|
|
FX_DOWNLOADHINTS* GetDownloadHints() const;
|
|
|
|
FPDF_BOOL IsDataAvail(size_t offset, size_t size) const;
|
|
void AddSegment(size_t offset, size_t size);
|
|
|
|
unsigned long GetFileSize();
|
|
|
|
int GetBlock(unsigned long position, unsigned char* pBuf, unsigned long size);
|
|
void SetRequestedDataAvailable();
|
|
void SetWholeFileAvailable();
|
|
|
|
private:
|
|
UnownedPtr<FPDF_FILEACCESS> file_access_;
|
|
std::unique_ptr<FileAccessWrapper> file_access_wrapper_;
|
|
std::unique_ptr<FileAvailImpl> file_avail_;
|
|
std::unique_ptr<DownloadHintsImpl> download_hints_;
|
|
RangeSet available_data_;
|
|
RangeSet requested_data_;
|
|
};
|
|
|
|
#endif // TESTING_FAKE_FILE_ACCESS_H_
|