6 Commits

Author SHA1 Message Date
Tom Sepez
1ca37e1f4f Enforce unsafe_buffers in testing/image_diff/ directory.
Remove the last non-gtest testing directory.

Change-Id: I8b60035116bb6341f15cbcc0fe4992856e5db925
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149150
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
2026-06-04 17:23:13 -07:00
Tom Sepez
4fab2ee66f Opt more testing/ sub-directories into unsafe buffers.
Remove the per-directory suppression, and suppress individual lines in
the files originated by PDFium. Help to avoid new unsafe usage from
being added in any future CLs.

Change-Id: I6b8591ecbf74c4857a02c6f4c28167bde0ce890d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149130
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
2026-06-04 16:58:35 -07:00
Tom Sepez
2fbebb9ef6 Enable new unsafe-buffers diagnostic for PDFium.
Check for std::unique_ptr<T[]>::operator[]. The code should already be
clean as we removed this idiom some time ago.

Change-Id: Ib74b39517cfe04e8bb96fc73ba19ed8d9fd816e2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/137710
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
2025-11-06 10:07:47 -08:00
Tom Sepez
df8678ac2d Remove base/ from PDFium unsafe_buffer_paths.txt file
Recent changes to partition alloc have made its files able to stand
up to this scrutiny.

Change-Id: I2fcf8fd91e7c392db83001056f9c34a76c5e47ba
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134750
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
2025-08-04 13:11:43 -07:00
Tom Sepez
ab8934ea5f Enable unsafe libc call warnings for PDFium.
-- Mark some non-compliant platform-specific code.

Change-Id: I371bbdb816a35b50bef77d4dbb991a5afe791968
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/129690
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
2025-03-18 19:36:59 -07:00
Tom Sepez
6be4f3be70 Rename pdfium_unsafe_buffers_paths.txt file
In preparation for a day in which the dependent product source trees
are searched for these unsafe suppression files, make the naming
consistent between chrome and pdfium.

Bug: 389830173
Change-Id: I0b4eba50015791c3fb34040401e42ae27b3b38e7
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/127891
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
2025-01-15 09:36:56 -08:00