Replace a number of UNSAFE_TODO() with a single one at the API
boundary.
Change-Id: Ica433bf356d98ab0bb629d4bfe7856e1a9786ff2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/151451
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Remove last usage of the std::unique_ptr<T[]> anti-pattern in favor
of a type that knows its size.
Change-Id: Ic42e07c984314b0d52d402dc1ab8b936c552a99b
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/115050
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Updates old-style copyright headers to the new style, by removing "All
rights reserved." Also inserts "The" before "PDFium Authors", which is
required by both styles.
Mechanically generated by this command:
PATTERN='Copyright \([0-9]\+\) \(The \)\?PDFium Authors. All rights reserved.'
git grep -l "$PATTERN" \
| xargs sed "s/$PATTERN/Copyright \1 The PDFium Authors/" -i''
Fixed: pdfium:1884
Change-Id: I6f781d811df8839e2e21b85f716529b813828bcd
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100371
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
1) Update pdfium_test with a --croscore-font-names switch. When this
switch is in use, pdfium_test will use FPDF_SetSystemFontInfo() to
activate a font mapper that maps common fonts to their croscore font
equivalent. The croscore fonts are already available in
third_party/test_fonts/.
2) Update testing/tools/test_runner.py to run tests with
--croscore-font-names and an appropriate --font-dir, depending on the
test.
3) Update testing/tools/make_expected.sh to use --croscore-font-names
and --font-dir, so the PNG files it produces remain compatible with
what pixel and corpus tests expect.
4) Since the croscore fonts set does not contain a font that is
compatible with the Symbol font, the bug_1449.in test case will
regress on platforms that have the Symbol font. Fix this by checking
in a copy of the SymbolNeu font, which is developed by Google. Move
the bug_1449.in test case and expectations to a "use_symbolneu"
sub-directory, similar to the "use_ahem" sub-directory, and update
the test runner to pass in the appropriate --font-dir for this case.
Then this not only avoids a test regression, but also make the test
case pass on Linux. Remove the test suppression entry accordingly.
Bug: pdfium:1792
Change-Id: I2c60aeb036aaf00407d7a7f6be6932ec8e72c3d1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/91990
Reviewed-by: Nigi <nigi@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Bug: chromium:1250250
Change-Id: I63d07673d308ee9ede4689a44681accad1ab8aa8
R=thestig
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/87190
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
