4 Commits

Author SHA1 Message Date
Badhri Ravikumar
f5cc1acdf3 Implemented Goto Action Handling for Internal links via key press.
Support for opening an internal link exists using mouse. But after
setting focus over internal link by pressing Tab key, we do not have
the provision to open the internal link using enter key press.
This implementation uses FFI_DoGoToAction API to handle opening an
internal link.

Bug: chromium:994500
Change-Id: I94fde897bc22c283d9304bffd093ee810ba128e8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68931
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Badhri Ravikumar <bravi@microsoft.com>
2020-04-30 19:00:55 +00:00
Badhri Ravikumar
dacaac7b0f Implemented URI Action Handling for links
Support for opening a link in new tab/window exists using mouse. But
after setting focus over link by pressing Tab key, we do not have the
provision to open the link in new tab/window using keyboard shortcuts.
This implementation uses FFI_DoURIActionWithKeyboardModifier API
which handles opening the link in new tab/window.

CL for tests : https://pdfium-review.googlesource.com/c/pdfium/+/66830

Bug: chromium:994500
Change-Id: I65500983d1a07e9b31743d0a0df88a1bde4eb142
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68930
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Badhri Ravikumar <bravi@microsoft.com>
2020-04-23 18:00:38 +00:00
Badhri Ravikumar
e86bbfabd6 Added URI Action handling public API and its test cases
Support for opening a link in new tab/window exists using mouse. But
after setting focus over link by pressing Tab key, we do not have the
provision to open the link in new tab/window using keyboard shortcut.
This new API carries keyboard modifier value whenever URI action
needs to be performed.

Embedder tests are added to validate the added APIs.

Bug: chromium:994500
Change-Id: Id1bb8d6dd5c607bc5194d300250d8b796c7ff03c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66830
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Badhri Ravikumar <bravi@microsoft.com>
2020-04-16 21:42:40 +00:00
Badhri Ravikumar
e8de0bb70c Tests added for Action handling of enter key press over buttons.
This CL contains embeddertests and pixel tests for verifying action to
be performed when enter key is pressed over buttons in PDF forms.

Upon receiving OnChar() event for button widget in
CFFL_InteractiveFormFiller, if pressed key is enter then associated
action is performed, e.g., reset form, goto URI.

Bug: chromium:1028991
Change-Id: I58826bb3f5650bf9997803a312a7f875ed14905c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68010
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Badhri Ravikumar <bravi@microsoft.com>
2020-04-03 08:15:36 +00:00