Bring "$root_gen_dir/third_party/skia into the include directory set.
-- Add missing fontations sources in anticipation of future usage.
Bug: 42271123
Change-Id: I4fdcd3e9511762b745d473965ffe090918d223a9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/143792
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
This has been empty for a while and Skia plans to delete it.
Change-Id: I20f22b798ce4eaa2911d76bc9085908e7cf575b2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/143290
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Roll build/ 26e5b4f1d..06d247cb9 (91 commits)
26e5b4f1d8..06d247cb91
Created with:
roll-dep build
Roll buildtools/ 4dc32b3f5..6a18683f5 (1 commit)
4dc32b3f51..6a18683f55
Created with:
roll-dep buildtools
Roll third_party/abseil-cpp/ 1597226b8..675d3d37e (5 commits)
1597226b82..675d3d37ec
Created with:
roll-dep third_party/abseil-cpp
Roll third_party/rust/ c45037002..7da7c8be1 (44 commits)
c450370025..7da7c8be1f
Then update crate versions in skia/BUILD.gn.
Created with:
roll-dep third_party/rust
Roll tools/rust/ d1690596d..8a3ca2dfc (11 commits)
d1690596df..8a3ca2dfc9
Created with:
roll-dep tools/rust
Roll tools/clang/ 5ec0da997..a1542f295 (13 commits)
5ec0da997c..a1542f2952
Roll clang llvmorg-22-init-17020-gbd1bd178-2 : llvmorg-23-init-2224-g5bd8dadb-1
Created with:
roll-dep tools/clang
Change-Id: I4596db833bfba3b787e3b3c7805417cf7ce868d8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/142154
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
It's always true after
https://chromium-review.googlesource.com/c/chromium/src/+/7262201
(Probably not rolled into pdfium yet, but should be fine landing
this before //build is updated. The build_overrides/build.gni change
even fixes one prerequisite for that.)
Bug: 469092869
Change-Id: I0a2179a629a304d26e4308f1d2b2c816504fe05d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/139950
Reviewed-by: Nico Weber <thakis@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
https://skia.googlesource.com/skia.git/+log/a1ff58d34294..a9e9573a3f
(330 commits)
This also removes old defines from SkPdfiumUserConfig.h that no
longer do anything in Skia. This will allow Chromium to be updated
to the newer versions of various APIs that take/return const SkDatas.
BUILD.gn changes for rust refactor were cribbed from
https://crrev.com/c/7130444
Change-Id: I991542c8f5f1e15cd55117d5ee0b898e4a6442c8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/138690
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Update Skia font dependency versions to match http://crrev.com/1522294.
Then roll.
Roll build/ f6b5f3e89..8c2e4caf4 (113 commits)
f6b5f3e896..8c2e4caf42
Created with:
roll-dep build
Roll third_party/rust/ ea2d1926a..84c4bbe80 (83 commits)
ea2d1926aa..84c4bbe803
Created with:
roll-dep third_party/rust
Roll tools/clang/ d2182ae5c..b82de5de2 (19 commits)
d2182ae5cc..b82de5de26
Roll clang+rust
llvmorg-22-init-8940-g4d4cb757-1:llvmorg-22-init-12326-g8a5f1533-1
Created with:
roll-dep tools/clang
Roll tools/rust/ 0eaaeed1c..f75012ad3 (5 commits)
0eaaeed1ca..f75012ad31
Created with:
roll-dep tools/rust
Change-Id: I6dd3cf3101c8f517b5486a425bfa851099b9ec12
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/137471
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
This supports changing the Skia API as discussed in
https://review.skia.org/1082338
Bug: 381900683
Change-Id: I00f6c56ac4bad1e1fb6cae978ddd1d37b21d6b22
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/137410
Auto-Submit: Łukasz Anforowicz <lukasza@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
This CL switches to using the new overload of `SkXPS::MakeDocument`
introduced in https://review.skia.org/1073497. The new overload forces
Skia users to explicitly choose which PNG encoder to use.
Bug: 381900683
Change-Id: I74c3d7ec514e5bea6f9cdb065018ec39a2feea99
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/137170
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
After this CL, if `pdf_enable_rust_png` GN arg is set, then PDFium tests
will use Rust-based PNG codec (instead of `libpng`-based one) from
`pdfium/testing/helpers/write.cc` and from
`testing/image_diff/image_diff_png...`.
Switching the production code underneath `core/fxcodec/png/...` is
deferred to a future CL (see
https://pdfium-review.googlesource.com/135730).
CLs that demonstrate test coverage of PDFium CQ:
- https://pdfium-review.googlesource.com/136111 - is an ad-hoc,
non-landable CL, which replaces `SkPngEncoder` usage in `write.cc`with
`NOTREACHED` to discover which tests cover it. All tests pass in this
CL (i.e. this path is not covered by CQ).
- https://pdfium-review.googlesource.com/136392 is a similar CL for
encoding/decoding path under `testing/image_diff/...` (there are a few
failing tests)
- https://pdfium-review.googlesource.com/136110 is a similar CL for
decoding path under `core/fxcodec/png/...` (there are a few failing
tests)
Bug: 444045690
Change-Id: Ica54e6e82d5646267242fd0a6d6538389bd18deb
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/135630
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@google.com>
In order to roll, perform the following:
1. Update skia/BUILD.gn to match the font versions in
https://crrev.com/c/6909036.
2. Update test expectations in RetainPtr.SetContains.
Roll third_party/abseil-cpp/ 77596c036..04fe3ac35 (7 commits)
77596c0368..04fe3ac35a
Roll build/ ac578f1d4..4d26bd650 (189 commits)
ac578f1d43..4d26bd6500
Roll buildtools/ 460cef896..10b037a66 (41 commits)
460cef8967..10b037a661
Roll third_party/libc++/src/ adbb4a521..954086abf (91 commits)
adbb4a5210..954086abf1
Roll third_party/rust/ 5f298b3f4..ea2d1926a (51 commits)
5f298b3f4b..ea2d1926aa
Change-Id: I44398ecf727111c68599361a0ade428b5ae50255
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/135590
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
8bbd6f5553..5f298b3f4b
Then update skia/BUILD.gn to use the newer library versions.
Created with:
roll-dep third_party/rust
Change-Id: I5fa4f44053f2077515bc2367d3f7ee8437ce5994
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134791
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
It is nacl nevermore.
Change-Id: Ibebeabc78ca5d81f37618516d6898fe80c94ccc3
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133590
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Roll build/ bcaac35c1..49491ecc7 (82 commits)
bcaac35c14..49491ecc7a
Created with:
roll-dep build
Roll third_party/rust/ c98072466..d05fde505 (39 commits)
c980724668..d05fde5052
Created with:
roll-dep third_party/rust
Roll tools/clang/ d05ab7b5b..374799d77 (9 commits)
d05ab7b5b9..374799d778
Roll clang llvmorg-21-init-5118-g52cd27e6-5 : llvmorg-21-init-6681-g5b36835d-1
Created with:
roll-dep tools/clang
Roll tools/rust/ f26c92c0d..b549758ca (2 commits)
f26c92c0db..b549758ca9
Created with:
roll-dep tools/rust
Then update skia/BUILD.gn to match the new Rust updates.
Change-Id: I8e27ee590e57268e9354dda10e0de3c1d0a5679f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/130570
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Roll build/ 3dd73ffc3..b802198dd (29 commits)
Created with:
roll-dep build
3dd73ffc37..b802198dd5
Roll tools/clang/ 2ca96532f..786a0cdb0 (30 commits)
2ca96532f8..786a0cdb02
Roll clang+rust llvmorg-21-init-853-gba476d0b-1 : llvmorg-21-init-1655-g7b473dfe-1
Created with:
roll-dep tools/clang
Roll third_party/rust/ 199a94c3f..7f2e44344 (19 commits)
199a94c3fa..7f2e443447
Created with:
roll-dep third_party/rust
Roll tools/rust/ dd2753500..8b154f583 (3 commits)
dd27535007..8b154f5837
Created with:
roll-dep tools/rust
Then update //skia/BUILD.gn to reference new Rust dependency versions.
Change-Id: I276ab4b8843f82c4f0eac22102907026a790b19a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/129350
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
These have all been deleted from the Skia codebase over the last
12 months or so.
Change-Id: Ib9c524ab0704ecb4ff9895b8d039fbbebb182976
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/128990
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
The explicit lists of port files declared here could become out of sync
with the files declared in the Skia repo. This can be more easily
maintained by using the gni port variables declared by Skia. This
ensures that any new or dropped files are automatically reflected here
in PDFium. Switching to these already corrects some discrepencies, such
as the removal of SkFontMgr_android_factory.cpp and the addition of
several other header files.
Change-Id: Ic6ae03a58b8a458e68c54b9260be6316b06b112d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/128830
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Roll third_party/abseil-cpp/ f9b083a49..221ee3ed3 (6 commits)
f9b083a49c..221ee3ed3b
Created with:
roll-dep third_party/abseil-cpp
Roll build/ 4aba7b76e..3dd73ffc3 (162 commits)
4aba7b76ec..3dd73ffc37
Created with:
roll-dep build
Roll buildtools/ 469b4146c..91b044f3878e (16 commits)
469b4146c5..91b044f387
Created with:
roll-dep buildtools
Roll tools/clang/ bf9a34113..2ca96532f (43 commits)
bf9a341137..2ca96532f8
Roll clang+rust llvmorg-20-init-16062-g091448e3-1 : llvmorg-21-init-853-gba476d0b-1
Created with:
roll-dep tools/clang
Roll third_party/libc++/src/ 74dd76082..61c68567c (130 commits)
74dd760826..61c68567ca
Created with:
roll-dep third_party/libc++/src
Roll third_party/llvm-libc/src/ 60b7db20a..533347237 (118 commits)
60b7db20ac..5333472378
Created with:
roll-dep third_party/llvm-libc/src
Roll tools/rust/ 474e007a4..dd2753500 (2 commits)
474e007a4e..dd27535007
Created with:
roll-dep tools/rust
Roll third_party/rust/ 08704ba66..199a94c3f (35 commits)
08704ba669..199a94c3fa
Created with:
roll-dep third_party/rust
Update Rust version numbers in Skia BUILD.gn to match.
Change-Id: I3552044e482868c92fc94858d597a8acce1c5c2f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/128711
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Add dependency llvm-libc
libc++ now depends on a small part of llvm-libc for floating point
from_chars. https://crrev.com/1375402
Roll GCS deps
Utilize the generated output from GCS dep autoroller in
https://pdfium-review.googlesource.com/c/pdfium/+/126017
Roll build/ 9b11bd3a6..fcec87a31 (220 commits)
9b11bd3a6a..fcec87a316
Created with:
roll-dep build
Roll buildtools/ 7f979120b..1760ff6d7 (25 commits; 1 trivial rolls)
7f979120bf..1760ff6d72
Created with:
roll-dep buildtools
Roll tools/clang/ 7566fe852..37d1894d5 (38 commits)
7566fe8521..37d1894d53
Created with:
roll-dep tools/clang
Roll third_party/libc++/src/ e2d898ca2..e9288ebce (75 commits)
e2d898ca22..e9288ebce4
Created with:
roll-dep third_party/libc++/src
Roll third_party/rust/ 0e0ef1487..7c0544c9d (65 commits)
0e0ef14876..7c0544c9d6
Created with:
roll-dep third_party/rust
Roll tools/rust/ a7d3d8af5..e4fd8fdee (15 commits)
a7d3d8af53..e4fd8fdeea
Created with:
roll-dep tools/rust
Add UNSAFE_TODO() to cps_printer_driver.cpp to workaround build failure
after the toolchain updates.
Change-Id: Ife6a10c6dc84e4934a09a88d33c26a3bcd7ec1be
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/126130
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
In http://review.skia.org/921634, Skia is removing a filegroup.
This update to PDFium will also make it so PDFium isn't building
the graphite SkSL modules (which are not used by PDFium).
Change-Id: Iabd65d7aeff8128d592066f87f24e2c4073151e6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/126290
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Also update Rust dependencies in skia/BUILD.gn to match.
Roll build/ 88f75356c..d26b9feb9 (99 commits)
88f75356c4..d26b9feb99
Created with:
roll-dep build
Roll buildtools/ f8f6777fc..e796a7e40 (24 commits)
f8f6777fcf..e796a7e40d
Created with:
roll-dep buildtools
Roll third_party/abseil-cpp/ 1b7ed5a19..ff8e7ea37 (8 commits)
1b7ed5a193..ff8e7ea37e
Created with:
roll-dep third_party/abseil-cpp
Roll third_party/libc++/src/ d8d9de41d..1fe5dc4db (85 commits)
d8d9de41d7..1fe5dc4dbb
Created with:
roll-dep third_party/libc++/src
Roll third_party/rust/ 3faea6d0c..1de58cd16 (29 commits)
3faea6d0cb..1de58cd165
Created with:
roll-dep third_party/rust
Roll tools/clang/ fb801f8a4..4f1bc3a6b (23 commits)
fb801f8a4b..4f1bc3a6bc
Roll clang+rust llvmorg-20-init-1009-g7088a5ed-10 : llvmorg-20-init-3847-g69c43468-1
Created with:
roll-dep tools/clang
Roll tools/rust/ b732825d2..a7d3d8af5 (5 commits)
b732825d28..a7d3d8af53
Created with:
roll-dep tools/rust
Change-Id: I725322bdb17882432bde4046f12989aae629089c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/124470
Reviewed-by: Tom Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
This is going away in https://skia-review.googlesource.com/892078
and PDFium does not use Skia's Ganesh backend so this is a no-op.
Bug: b:293490566
Change-Id: If75beed66b12b1808a1129fbf0344e1182bf1891
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/123710
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Import the Fontations build rules from Chromium's //skia/BUILD.gn into
PDFium's. The build rules are gated behind the `pdf_enable_fontations`
GN arg, similar to how Fontations was first introduced into Chromium.
Bug: 42271123
Change-Id: Ifd632dd928ace32883c27f17d2826e1007dfd3ec
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/121353
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Take a step towards building Fontations by building some of its Rust
dependencies.
- Check out third_party/rust to make those dependencies available.
- Rename some rust variables in DEPS to make them clearer.
Bug: 42271123
Change-Id: Ia34dc4a720a04bd12abd6e0f9c523d8ebf909c7b
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/121250
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Skia no longer supports use of Sfntly as a font subsetter, remove this
unused mention to clarify this.
Change-Id: I08ce184bf3a75de45f4fcc1917719964669514ce
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/117690
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
This CL synchronizes PDFium's Skia build files with Chromium's.
See https://crrev.com/c/5038351
Bug: b/310927123
Change-Id: I00b0df7ff189a3863f2ae8bbbc68b98dea78f2f5
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/113670
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Remove many #defines that are no longer set in Chromium's
//skia/config/SkUserConfig.h. Most of these have no effect on Skia.
Change-Id: I2ee4d0a4d30a89ba159f243e0f2a319e713496c6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/112933
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>
Except PDFium needs to add SkFontMgr_win_dw_factory.cpp to the build,
whereas Chromium separately implements a factory that does mostly the
same thing.
Bug: pdfium:1830
Change-Id: Id89997ea62621af4c08dd305563a69b61aa04f34
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/112891
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>
Enable rendering with CoreText on Mac, to match Skia in Chromium.
Update tests with new expectations and suppress some failures revealed
by the config change.
Bug: pdfium:1830,pdfium:2086
Change-Id: I95fb02518958619be62f77675f8c4d7c0a186c91
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/112831
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>
Make //skia/BUILD.gn consistent with Chromium's //skia/BUILD.gn. Disable
various legacy Skia APIs to ensure PDFium does not accidentally use
them.
Change-Id: I95f6983859a9260aa8dffd0824e69dcd2b78c503
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/112870
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
