No functional change.
Change-Id: Icb23e43853c8b0afb67c19ad690c3bfb81061b17
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149930
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
This CL replaces the EM_ADJUST macro with the CFX_Face::EmAdjust()
function. This allows the define to be removed and replaced with more
strict type checking and helps in removing legacy code.
Bug: 42270078
Change-Id: Id5f1b472391a4da169e977188ea6d46db6a8c129
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149110
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Commit-Queue: Aryan Krishnan <aryankrishnan4b@gmail.com>
These objects are unreachable, but it doesn't hurt to be more defensive
about clearing out old bindings.
Fixed: 522938824
Change-Id: I58e1f2de98a459231f87e3291fc3748edc3b9925
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149910
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
These macros were just short-name aliases for FX_LINEBREAKTYPE enum
values, used to keep the kLineBreakPairTable rows compact. Convert them
to file-scope constexpr constants in the anonymous namespace, and drop
FX_LBHS which was defined but never referenced. clang-format repacks the
data table to use the new shorter identifiers.
Bug: 42270078
Change-Id: I347b362a9af552682d28923355b40ee55a565e5d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148831
Auto-Submit: Helmut Januschka <helmut@januschka.com>
Commit-Queue: Helmut Januschka <helmut@januschka.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Mechanically move Skia font tables, constants, and helper functions from
CFPF_SkiaFontMgr to CFX_AndroidFontInfo.
Expose the necessary helper functions and table getters in
cfx_androidfontinfo.h to allow CFPF_SkiaFontMgr to continue using them
temporarily.
This is a preparatory step to simplify the transition of
CFX_AndroidFontInfo to inherit from CFX_FolderFontInfo and remove
CFPF_SkiaFontMgr.
-- Pass tables back to old code as spans.
TAG=agy
CONV=9eb75345-7937-424f-b361-4fdfac3d86a7
Change-Id: Iedad112f2d1de8039e4cba198730305ccd1f2da5
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149870
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Add infrastructure changes to CFX_FolderFontInfo to support Android's
font matching requirements in a subsequent CL.
Changes:
- Add `glyph_count_` to FontFaceInfo.
- Parse 'maxp' table in CFX_FolderFontInfo::ReportFace to extract
`glyph_count_` during scanning. This information is the crux of
the change, allowing android to drop FreeType usage in next CL.
- Add virtual IsBetterMatch hook to CFX_FolderFontInfo, replacing
inline matching logic in FindFont.
- Minor cleanup in FindFont to assign `pFind` alongside `iBestSimilar`.
TAG=agy
CONV=71ddca6b-8a59-46ab-a366-5526235fb713
Change-Id: I1480e3e0aafe45e1df307d5b88fdb026b018ad67
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149630
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Doing so will allow CFX_AndroidFontInfo to re-use this code in
a subsequent CL. No functional change.
Change-Id: I3ed34ed91581bf46165e3dca215a88b7bc316191
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149711
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
VRP reports via the Chromium template are deprecated.
Bug: b:518804997
Change-Id: I1699494689808e9950d94e3cf05115af3c9a0414
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149710
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Alex Gough <ajgo@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Expand CFX_FolderFontInfo to support Vietnamese and OEM charsets, and
correctly map Johab to FX_Charset::kJohab (instead of Hangul) when
scanning system fonts. This benefits all platforms using the shared
folder font scanner (like Linux and eventually Android).
TAG=agy
CONV=71ddca6b-8a59-46ab-a366-5526235fb713
Change-Id: Idbee3b04440e6efd347c2bfd717b833f31b015e3
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149650
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Hebrew fallback now succeeds and selects a proper Hebrew fallback font
(Sans-Serif, like DejaVu Sans), causing the rendering to change. Makes
other platforms more consistent with android font mapping, allowing
unification down the road.
-- Update diffing image.
Change-Id: I92f40426c99354e13588ac62788fc4893464fb2c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149450
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Move the Android Skia font manager's charset bitmask concept into a
global FX_CharsetFlag enum class in core/fxcrt/fx_codepage.h.
Refactor CFPF_SkiaFontMgr and CFX_FolderFontInfo to use this new
global enum instead of their own local charset representations.
-- Document origin of some magic constants.
TAG=agy
CONV=818eabd3-5feb-4f7e-8419-5bdf50c0ebd6
Change-Id: I89516de04fa4d8a38be827169bbd8e5a4a35ac28
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149590
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Convert the three pushbutton highlight-mode bits to a scoped enum
HighlightStyle nested in CXFA_FFPushButton, unwrapping to uint32_t via
fxcrt::to_underlying() only at the ModifyStyleExts/GetStyleExts
boundary.
Bug: 42270078
Change-Id: I46a424e1302d7c47b16cd07dca2a960f419920ec
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148813
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Helmut Januschka <helmut@januschka.com>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Simplify one constexpr function with it.
Change-Id: I8e0dc4c7b278a4b8a4ad54b73da3244a35d08b18
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149570
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
This CL adds test based on brotli-stream compressed PDF files and
updates the needed BUILD files to be able to allow for Brotli
compression to be tested when the feature is built. These test files are
based on existing files with a compressed stream using brotli and
ASCII85 decode to prevent the stream from just being a binary blob.
Bug: 475855993
Change-Id: I8162dd98885cf6e75bfe8b5d82f61d7d4252bea1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148230
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Swap the existing CPDF_Object elements in-place within the limits array
instead of recreating CPDF_String objects. This avoids unnecessary
object destruction and creation, and prevents raw pointers to these
objects from becoming stale.
TAG=agy
CONV=0a224b86-8e8f-46de-aa9b-83554f270ca5
Fixed: 522299155
Change-Id: Ib7615898a5fb489cb7755f1e3f1d04f95715e08a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149550
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
For compatibility reasons, the Android font mapping can not be
converted to a pure string-to-string mapping (yet) because some source
font names in the mapping table remain unknown (undecoded).
However, all target fonts are common names (Roboto, Droid Sans, Droid
Serif, Droid Sans Mono, Droid Sans Fallback). This CL converts the
substitution tables to map from source hashes to target string names.
Hash the mapped target string back to a hash on the fly to keep the
rest of the matching logic unchanged.
Knowing the font name will help subsequent CLs integrate with
CFX_FolderFontMgr.
Added a constexpr helper and static_asserts to verify all decoded
font name hashes at compile time. We can pull this in a subsequent CL.
TAG=agy
CONV=77ae3c3f-4d26-44e9-b5f1-623838abecd3
Change-Id: I6b53a7a18b58096a3e8633c2eedeb44b1a676add
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149370
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
A follow-on CL tries to use one in a constexpr context.
-- rewrite to avoid non-constexpr calls.
-- static_assert in unit test that they exist in constexpr context.
Change-Id: I40edf178cb3b7915e9dcde3619ddb3776ece6676
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149510
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Adds LTR and RTL text layout test cases. For RTL, the test currently
verifies the existing (incorrect) LTR fallback behavior where X
coordinates increase as characters are typed.
Bug: 40115028
Change-Id: Ia19a7472cb3731571c33fbfed127b2d15c6cb3f8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149190
Commit-Queue: Seung Hyun Jin <seunghyunjin@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Validate tiling pattern step values before using them to compute tile
iteration bounds, and reject non-finite or out-of-range rounded values
before casting them to int.
Add a regression test for a malformed tiling pattern that omits XStep
and YStep, which previously could produce non-finite loop bounds during
rendering.
Bug: 509964646
Change-Id: I5da3fe15b5afde3071ba88d9b7ab28a06b4358a9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149290
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Convert the file-local FXMATH_DECIMAL_SCALELIMIT and the two 32-bit
shift helper macros into proper constexpr declarations:
- FXMATH_DECIMAL_SCALELIMIT becomes constexpr int kDecimalScaleLimit.
- FXMATH_DECIMAL_RSHIFT32BIT(x) becomes constexpr Rshift32Bit
returning uint32_t (the top 32 bits of a uint64_t always fit),
which matches how every existing caller used the result.
- FXMATH_DECIMAL_LSHIFT32BIT(x) becomes constexpr Lshift32Bit
returning uint64_t.
Bug: 42270078
Change-Id: I205f8539a3bed737baa5dc7e8921936334287ed5
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148833
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Auto-Submit: Helmut Januschka <helmut@januschka.com>
Issue noticed by Gemini while working on an unrelated manner. Appears to
have been wrong since the initial checkin. Ignored in CFX_FontMapper,
but tested in DefaultGetFontCharset(). The former is more important, so
this affected very little.
Change-Id: Ib645cc1a061ee3353438bf8024b8cc98aa69c06f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149470
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
This fixes checkout_configuration=minimal.
Change-Id: I7be8c7b17ad48f2abaa5970ea5fd0f1a1f6c3a18
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149310
Reviewed-by: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Bring the enum class and its values in line with PDFium naming
conventions by dropping the FX_ prefix, switching values from
SCREAMING_SNAKE to CamelCase, and spelling out BRK as Break/Common.
Bug: 42270078
Change-Id: I949be71f751c7255a5f92e0f8011e7c49f13cf5e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148832
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Auto-Submit: Helmut Januschka <helmut@januschka.com>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Use an anonymous namespace constant instead of a preprocessor macro.
Bug: 42270078
Change-Id: Ice5f22c2ffd030326a8619237cd0d591035b7a14
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148770
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Helmut Januschka <helmut@januschka.com>
Avoid a copy of a std::array<> in the process by inlining init in
the constructor itself.
Change-Id: I561ffc3a66ace36f0a839bd7c8830add2dc75739
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149270
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Introduce safe, container-templated span-based I/O wrappers. Helps
centralize some UNSAFE_BUFFERS() usage.
-- Add spanread/spanwrite overloads for FILE*.
-- Add spanread/spanwrite overloads for POSIX file descriptors.
-- Add spanread/spanwrite overloads for Windows HANDLE.
-- Change FileAccessIface::Write() signature to return bool.
-- Update image_diff, write.cc, file_util, and cfx_folderfontinfo.
-- Update CFX_FileAccess_Posix to use FD wrappers.
-- Update CFX_FileAccess_Windows to use HANDLE wrappers.
-- Update TemporaryFileTest to use safe spanwrite wrapper.
-- Add unit tests for all overloads in span_util_unittest.cpp.
Note that CFX_FileAccess_Posix changes may have fixed a latent error
underflow bug in the process.
Change-Id: Ic2c4088d364be0a2f38c5d30854a61fdacc6c69d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149030
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Put both constants near each other in the header to ease validation.
Bug: 520531611
Change-Id: Ia68aafcb8a329a352e91f600c40582cfa2c8b3ad
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149250
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Create constants/catalog.h with some of the entries from the spec. Use
the constants where applicable.
Bug: 42270045
Change-Id: Id1edafe9c8defd7ca574dc8787524794379bb9c6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149230
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
This CL adds pdf_enable_brotli_override as a build override in PDFium to
temporarily make the feature off by default until PDF 2.0 spec is
confirmed.
Bug: 475855993
Change-Id: I7e72610b65e9971425faa05fc8c7516be514d062
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148990
Reviewed-by: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Take Chromium's copy to avoid a GN gen error following a build roll.
Otherwise, trying to build some rust targets will fail.
Change-Id: Id2de4260b0c85edca0bc3bfe2c67ceaa2f9ed26f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149191
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Remove the last non-gtest testing directory.
Change-Id: I8b60035116bb6341f15cbcc0fe4992856e5db925
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149150
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Remove the per-directory suppression, and suppress individual lines in
the files originated by PDFium. Help to avoid new unsafe usage from
being added in any future CLs.
Change-Id: I6b8591ecbf74c4857a02c6f4c28167bde0ce890d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149130
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Limit CPWL_ListCtrl::ReArrange() to walk from the requested item index.
Add a pixel test covering a focused list box with a visible selected
item.
Bug: 477200528
Change-Id: I6c71184704d5a0632d235cc328c42990b45b3d1c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148610
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Update comments referencing the "PDF 1.7 spec" to point to their
corresponding tables and sections in the ISO 32000-1:2008 specification.
Hopefully nobody will need to open pdf_reference_1-7.pdf anymore after
this.
TAG=agy
CONV=e172d025-7526-4dbc-b51d-9fdabcf46a76
Change-Id: I80544bd4df3829cb9292199e9dac7d223b2377a1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149091
Reviewed-by: Andy Phan <andyphan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Change-Id: Ib432e4ca1850140af674d57671fae29315c8103a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149054
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: April Kallmeyer <ask@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Change-Id: Id49014c74d14ef95151ad016531e2fbe5d4730f4
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149053
Reviewed-by: Andy Phan <andyphan@chromium.org>
Auto-Submit: April Kallmeyer <ask@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
71192be150..d6c7a21e97
Created with:
roll-dep third_party/libunwind/src
Change-Id: I877190812038eaee009355231b0c9281b70a78a5
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149033
Reviewed-by: Andy Phan <andyphan@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Auto-Submit: April Kallmeyer <ask@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
d16e6b55b2..faefd1b6fa
Created with:
roll-dep tools/win
Change-Id: I8d524f995b8bd4d503f9f468abd9017951c390eb
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149051
Commit-Queue: Andy Phan <andyphan@chromium.org>
Auto-Submit: April Kallmeyer <ask@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
08cce2b81a..6eddfb5ec5
Created with:
roll-dep third_party/clang-format/script
Change-Id: I2bede08a14f581b30c955b48adf90a36d1d34f4d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/149032
Auto-Submit: April Kallmeyer <ask@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
The same //third_party/llvm-libc/BUILD.gn change was made in Chromium in
https://crrev.com/1627152. It is required of v8 embedders now.
8e10f842e4..0c6c73eea6
Version 15.0.245
Created with:
roll-dep v8
Change-Id: Iac2b50617c192040081a0741a0f7ce97ee7a42b8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148952
Auto-Submit: April Kallmeyer <ask@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
This CL helps modernise the codebase by replacing the c-style casts in
cfgas_decimal.cpp with static_casts.
Change-Id: Ifd3a96313e51048c2f8afcf7d8d45c6f312ac378
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148851
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Commit-Queue: Aryan Krishnan <aryankrishnan4b@gmail.com>
